Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix engine dependency version for Node versions > 11.1.0 #1169

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

duncand
Copy link
Contributor

@duncand duncand commented Nov 27, 2018

Summary

Proposed change:

Fix engine dependency version for Node versions > 11.1.0;
now there is only a minimum Node dependency and not a maximum dependency;
the engine dependency is now a blacklist rather than a whitelist;
it indicates Node versions that are known NOT to work, and unknown future
versions are accepted by default rather than rejected by default.

This fixes a systematic problem where Nunjucks and all of its downstream
dependencies break every time a new Node version is released, despite the
Node update being backwards compatible, thus forcing a new Nunjucks
release such as 3.1.4 until the goalpost is soon moved again.

Closes #1168 .

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@Diokuz
Copy link

Diokuz commented Dec 3, 2018

Guys, we need that thing)

@anru
Copy link

anru commented Dec 3, 2018

@fdintino pleeeease

@jcnventura
Copy link

Please merge!

@yogevyuval
Copy link

Let's merge this thing :)

@fdintino fdintino merged commit be3646b into mozilla:master Dec 13, 2018
@fdintino
Copy link
Collaborator

Thank you for this PR. I'll likely edit the changelog entry for brevity on release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn add nunjucks throws an error
6 participants